Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remaining tests #382

Open
wants to merge 119 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
119 commits
Select commit Hold shift + click to select a range
a8414f8
Add user class skeleton
cieragrace Dec 3, 2022
cd4d448
Add User test pseudocode
cieragrace Dec 3, 2022
6ae0b7f
Merge pull request #1 from cieragrace/feature/user-class
crgweller Dec 3, 2022
16d19d7
Add UserRepo pseudocode
keenans1 Dec 3, 2022
671a0bb
Add UserRepo test pseudocode
keenans1 Dec 3, 2022
4a5f327
Merge pull request #2 from cieragrace/feature/user_repo
cieragrace Dec 3, 2022
77498bb
Create basic HTML skeleton
AnnaPete Dec 3, 2022
ea1d77b
Comment out alert message
AnnaPete Dec 3, 2022
7c0bc47
is a function test
crgweller Dec 3, 2022
fb33de5
instantiate a user test
crgweller Dec 3, 2022
f9be920
userdata parameter test
crgweller Dec 3, 2022
c2614fa
userdata id test
crgweller Dec 3, 2022
c189d69
Change id numbers to match index positions
AnnaPete Dec 3, 2022
3a08f23
add userdata name test
crgweller Dec 3, 2022
dbfc32b
add user address test
crgweller Dec 3, 2022
cbf0fb5
Merge pull request #3 from cieragrace/feature/basic-html
cieragrace Dec 3, 2022
5724ad2
add user email test
crgweller Dec 3, 2022
389245f
add user stridelength test
crgweller Dec 3, 2022
a54fb50
add user step goal test
crgweller Dec 3, 2022
c7df35b
add user friends test
crgweller Dec 3, 2022
0983f01
update testing parameter names
crgweller Dec 3, 2022
f0dbdd5
update some syntax
crgweller Dec 3, 2022
c01e998
refactor and add beforeeach
crgweller Dec 3, 2022
15916ff
Merge pull request #4 from cieragrace/feature/users.js-testing
keenans1 Dec 3, 2022
046d2f7
Add getFirstName method
cieragrace Dec 3, 2022
a952749
Add new instance test
cieragrace Dec 3, 2022
25c22f6
Add take in data test
cieragrace Dec 3, 2022
c2692bb
Add id supplies data test
cieragrace Dec 3, 2022
8650f22
Add average stap method test
cieragrace Dec 3, 2022
96e0158
Merge pull request #5 from cieragrace/feature/userRepository-testing
AnnaPete Dec 3, 2022
9066a49
Add classes to grid elements
AnnaPete Dec 3, 2022
46a200f
Add css styling to grid items
AnnaPete Dec 3, 2022
7dcfa5d
Merge pull request #6 from cieragrace/feature/basic-css
cieragrace Dec 3, 2022
be97505
Add user1 instance to test file
keenans1 Dec 4, 2022
5c87e16
Add user2 instance to test
keenans1 Dec 4, 2022
bc9c557
Add user3 instance to test file
keenans1 Dec 4, 2022
b645a97
Add skips to all tests and pass first test
keenans1 Dec 4, 2022
f95b201
Add beforeEach
AnnaPete Dec 4, 2022
078abff
Pass class instantiation and parameter testing
keenans1 Dec 4, 2022
0c20f09
Pass test 4
keenans1 Dec 4, 2022
743a9b7
Pass user test number 5
keenans1 Dec 4, 2022
0c08729
Pass address test
keenans1 Dec 4, 2022
2bca2ac
Pass email test
keenans1 Dec 4, 2022
052e015
Pass stride length test
keenans1 Dec 4, 2022
6c7ffa1
Pass step goal test
keenans1 Dec 4, 2022
63f1c90
Pass friends test
keenans1 Dec 4, 2022
f40e2b8
Add getFirstName method and pass corresponding test
keenans1 Dec 4, 2022
a0a8ed8
Remove all comments
keenans1 Dec 4, 2022
270eb5a
Merge pull request #7 from cieragrace/feature/user-test-buildout
crgweller Dec 4, 2022
a4175f2
Add beforeEach to user repo
AnnaPete Dec 4, 2022
de41607
Merge branch 'main' into feature/build-user-repo
cieragrace Dec 4, 2022
c1a589b
Merge pull request #8 from cieragrace/feature/build-user-repo
crgweller Dec 4, 2022
102af27
Pass tests
AnnaPete Dec 4, 2022
11402f2
Write and pass test on line 43
AnnaPete Dec 4, 2022
5f27c9e
Write and pass test for avg step goal
AnnaPete Dec 4, 2022
f73e578
Add methods for getData and stepGoalAverage
AnnaPete Dec 4, 2022
22957ea
Merge pull request #9 from cieragrace/feature/build-user-repo
cieragrace Dec 4, 2022
647d5e5
Add imports and getUser method start
cieragrace Dec 5, 2022
dd7ffc4
Add commented out section names
cieragrace Dec 5, 2022
e29635d
Add infoBox query selector
cieragrace Dec 5, 2022
8951594
Connect HTML to DOM
cieragrace Dec 5, 2022
be1aee5
Add and remove scripts.js
cieragrace Dec 5, 2022
e814a15
Add export
cieragrace Dec 5, 2022
551c2cc
Add formatting
cieragrace Dec 5, 2022
3f21165
Merge pull request #10 from cieragrace/feat/iteration-1-dashboard
AnnaPete Dec 5, 2022
d31a831
Add HTML titles to grid boxes
cieragrace Dec 5, 2022
ff29ac9
Add event listers and query selectors
cieragrace Dec 5, 2022
2ee4588
Write fetch call for all data
AnnaPete Dec 6, 2022
1e48ef4
Write promise all, refactor getUser function
AnnaPete Dec 6, 2022
0834a6e
Move .catch statement to scripts file
AnnaPete Dec 6, 2022
74213ae
Refactor getUser function to get a current user
AnnaPete Dec 6, 2022
41a0876
Merge pull request #11 from cieragrace/layout/query-selectors
crgweller Dec 6, 2022
65658e4
add a user class instantiation
crgweller Dec 6, 2022
72185a0
add user name display
crgweller Dec 6, 2022
1280e0b
update getfirstname function
crgweller Dec 6, 2022
85bb263
display most users info
crgweller Dec 6, 2022
dc027f6
add user repo class instantiation
crgweller Dec 6, 2022
c804384
add users friends function and update getdata function
crgweller Dec 6, 2022
5aa82ef
refactor to remove console logs
crgweller Dec 6, 2022
f007b85
add dynamic step goal display
crgweller Dec 6, 2022
1d2cacf
add average step goal comparison
crgweller Dec 6, 2022
6968f17
Merge pull request #13 from cieragrace/feature/eventhandlers
AnnaPete Dec 6, 2022
40d5045
Merge branch 'main' into feature/fetch-calls
cieragrace Dec 6, 2022
e155976
Merge pull request #12 from cieragrace/feature/fetch-calls
cieragrace Dec 6, 2022
50ad33e
Debug errors in getAllData function
cieragrace Dec 7, 2022
6c80d9b
Comment out file to check API is working
cieragrace Dec 7, 2022
2f6ab87
Clean up formatting
cieragrace Dec 7, 2022
cb11837
Merge pull request #19 from cieragrace/cleanup/iteration2
crgweller Dec 7, 2022
879cbc5
Add parameters in getUser function
cieragrace Dec 7, 2022
3997568
Add tests for Sleep class
cieragrace Dec 7, 2022
1d5257d
Merge pull request #20 from cieragrace/feature/sleep-class
crgweller Dec 7, 2022
0075aa6
Fixed errors
AnnaPete Dec 7, 2022
11ff59a
Fixed errors and refactored code
AnnaPete Dec 7, 2022
4fb0dce
Begin writing code for avg daily water
AnnaPete Dec 7, 2022
1bfe06d
Refactored hydration sample data
AnnaPete Dec 7, 2022
e6bfbd4
Fix semicolons
cieragrace Dec 7, 2022
9a2dff5
Refactor getData method
cieragrace Dec 7, 2022
f7bb23c
Refactor failing methods
cieragrace Dec 7, 2022
e1c4e6b
update tests with API data
cieragrace Dec 7, 2022
9f0a0d9
Update instances
cieragrace Dec 7, 2022
2771cf2
refactor tests with API data
cieragrace Dec 7, 2022
08fa171
Add changes to methods
AnnaPete Dec 7, 2022
3a5f43a
Add changes to method test
AnnaPete Dec 7, 2022
8c310dc
Add minor changes
AnnaPete Dec 7, 2022
cc029b8
Merge pull request #27 from cieragrace/refactor-failing-tests
AnnaPete Dec 7, 2022
0b39f8b
Merge branch 'main' into feature/hydration-class
keenans1 Dec 7, 2022
15128a1
Merge pull request #28 from cieragrace/feature/hydration-class
keenans1 Dec 7, 2022
a065aad
Refactor user test structure
AnnaPete Dec 8, 2022
adb2895
Fix fetch call - promise
AnnaPete Dec 8, 2022
7b7271c
Add functionality to avg daily water method
AnnaPete Dec 8, 2022
a646f3f
Add functionality to getWaterPerDay method
AnnaPete Dec 8, 2022
77e89b0
Modify tests and add expect
AnnaPete Dec 8, 2022
0d4eaea
Add sleep test for avg hours
AnnaPete Dec 8, 2022
475cc9b
Merge pull request #29 from cieragrace/feature/hydration-class
cieragrace Dec 8, 2022
21818e5
Restructure user-repo-test
keenans1 Dec 8, 2022
568c313
fix return first name test
crgweller Dec 8, 2022
54eb656
update user data test
crgweller Dec 8, 2022
f789fb0
fix final user tests
crgweller Dec 8, 2022
5a79342
delete redundant code
crgweller Dec 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add userdata name test
  • Loading branch information
crgweller committed Dec 3, 2022
commit 3a08f2301aa8706d992ed9779159a29fc48f4f89
5 changes: 5 additions & 0 deletions test/User-test.js
Original file line number Diff line number Diff line change
@@ -27,6 +27,11 @@ describe('User', () => {
expect(user.id).to.equal(userData[id]);
})

it('should have an id', function () {
let user = new User(userData);

expect(user.name).to.equal(userData[name]);
})