feat(2.5): Batch Flash Nodes #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrenechea
commented
May 23, 2024
| function Flash() { | ||
| const { data: aboutData } = useAboutTabData(); | ||
| const batchFlashingSupport = useMemo( | ||
| () => isSemverGreaterOrEqual(aboutData.board_revision, "2.5"), |
There was a problem hiding this comment.
Here, I'm assuming the new hardware feature is incremental (e.g., the Turing 2.6, 2,7, and so on will also have batch flashing). It's not something to worry about right now, but if that's not the case in the future, it may need revision.
barrenechea
force-pushed
the
batch-flashing
branch
from
0a9d9c6 to
0ca3047
Compare
barrenechea
force-pushed
the
batch-flashing
branch
from
0ca3047 to
13b8826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft to add visibility on changes & things to do.
This PR adds the feature discussed in turing-machines/BMC-Firmware#201. It evaluates the users' board revision to render the
Flash Nodetab in either "Single mode" or "Batch mode". I've replaced theSelectinput withTogglebuttons 😄From the end-user perspective, it could choose a single node (as it currently works for v2.4 boards), but now, for >=2.5, the UI will allow it to select more than one node.
TODO list:
Add a skeleton to theDone 🚀Flash NodetabPreviously, this view didn't require any data from the server to render, so it did not require a skeleton. Now it requires the
board_revisionfield, and so as a good practice, it should have a skeleton available to render in-between the network call and the final render.bmcdto implement the&batch=1,2,3logic required for >=v2.5 boards and validate expected behavior.GIFs!
Rendered view for v2.4 users:
Rendered view for v2.5 users (view wording also changes into plural):
Bumping minor to v3.4.0 following SemVer.