feat: internationalization #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once again a quality commit. flashed it, did not see any regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature I have wanted to add since I started playing with
bmc-ui!I'm leveraging react-i18next to handle the logic and add a new
src/localefolder containing all languages.The
enlanguage is the fallback language if the user's preferred languages are not available. Its keys are based on the existing texts across the app and the foundation for newly added languages.I also added Spanish, German, Dutch, Polish, and Simplified Chinese, which have been generated by GPT4o. I manually validated the Spanish translation (it is my native language), but it would be good to validate the other languages over time, adjusting wherever needed.
For a more unified experience, I replaced the
ThemeTogglecomponent with a newUserNavcomponent:The Logout button was just a nice addition, considering there was no Logout button before 😜
Bumping minor, now it is at
v3.2.0. The last commit's build size, as reported by my computer: