fix: instances column of gcp_compute_instance_group errors for region…

…al groups
turbot · Oct 19, 2024 · d05048c · d05048c
1 parent 5bbdb77
commit d05048c
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/gcp/table_gcp_compute_instance_group.go b/gcp/table_gcp_compute_instance_group.go
@@ -259,14 +259,21 @@ func getComputeInstanceGroupInstances(ctx context.Context, d *plugin.QueryData,
  return nil, err
  }
 
- resp, err := service.InstanceGroups.ListInstances(project, getLastPathElement(types.SafeString(instanceGroup.Zone)), instanceGroup.Name, &compute.InstanceGroupsListInstancesRequest{}).Do()
-
- if err != nil {
- plugin.Logger(ctx).Error("gcp_compute_instance_group.getComputeInstanceGroupInstances", "api_err", err)
- return nil, err
+ if instanceGroup.Zone == "" {
+ resp, err := service.RegionInstanceGroups.ListInstances(project, getLastPathElement(types.SafeString(instanceGroup.Region)), instanceGroup.Name, &compute.RegionInstanceGroupsListInstancesRequest{}).Do()
+ if err != nil {
+ plugin.Logger(ctx).Error("gcp_compute_instance_group.getComputeInstanceGroupInstances", "api_err", err)
+ return nil, err
+ }
+ return &resp.Items, nil
+ } else {
+ resp, err := service.InstanceGroups.ListInstances(project, getLastPathElement(types.SafeString(instanceGroup.Zone)), instanceGroup.Name, &compute.InstanceGroupsListInstancesRequest{}).Do()
+ if err != nil {
+ plugin.Logger(ctx).Error("gcp_compute_instance_group.getComputeInstanceGroupInstances", "api_err", err)
+ return nil, err
+ }
+ return &resp.Items, nil
  }
-
- return &resp.Items, nil
 }
 
 //// TRANSFORM FUNCTIONS