Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add[#204]: an example to create basic RDS database #260

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

vivekvr1
Copy link
Contributor

@vivekvr1 vivekvr1 commented Nov 1, 2023

Closes: #204

Be noted that 204 is the issue ID

What is the purpose of the change

  • This pull request adds an example to create a basic RDS database in the getting-started/rds/create-simple-rds directory. This will help users to learn how to create and manage RDS databases using Terraform.

Add a description of the overall background and high level changes that this PR introduces

  • Added a new directory called getting-started/rds/create-simple-rds.
  • Added a new file called main.tf to the getting-started/rds/create-simple-rds directory.

Copy link
Owner

@tungbq tungbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @vivekvr1

@tungbq tungbq merged commit 02dc645 into tungbq:main Dec 3, 2023
@tungbq
Copy link
Owner

tungbq commented Dec 3, 2023

It seems that the code you provided did not work. @vivekvr1
I've created another fix to make it's working.

  • Result
    image

https://github.com/tungbq/aws-lab-with-terraform/pull/273/files

It should be better if we could do a trial run on the code of the pull request before requesting a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws/rds: add an example to create basic RDS database
2 participants