Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse out empty params from queries #2131

Merged
merged 1 commit into from
Sep 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/search_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def process_is(value, op)
end

def substitute_special_chars(value, _)
value.gsub(/[:?]/, " ") rescue value
value.gsub(/([:?]|\(\))/, " ") rescue value
end

def no_journals(solr_parameters)
Expand Down
8 changes: 8 additions & 0 deletions spec/models/search_builder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,14 @@
# @see BL-1301 for ref. Basically Solr treats ? as a special character.
expect(subject.substitute_special_chars("foo bar?", nil)).to eq("foo bar ")
end

it "substitutes empty parens '()' " do
expect(subject.substitute_special_chars("foo () bar", nil)).to eq("foo bar")
end

it "does not substitutes parens containing values " do
expect(subject.substitute_special_chars("foo (bar) baz", nil)).to eq("foo (bar) baz")
end
end

describe "#blacklight_params" do
Expand Down