Merge pull request #2131 from tulibraries/handle-empty-parens

Parse out empty params from queries
tulibraries · Sep 16, 2020 · a8de368 · a8de368
2 parents 0ac64b9 + d9092ea
commit a8de368
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/models/search_builder.rb b/app/models/search_builder.rb
@@ -106,7 +106,7 @@ def process_is(value, op)
  end
 
  def substitute_special_chars(value, _)
- value.gsub(/[:?]/, " ") rescue value
+ value.gsub(/([:?]|\(\))/, " ") rescue value
  end
 
  def no_journals(solr_parameters)

diff --git a/spec/models/search_builder_spec.rb b/spec/models/search_builder_spec.rb
@@ -183,6 +183,14 @@
  # @see BL-1301 for ref. Basically Solr treats ? as a special character.
  expect(subject.substitute_special_chars("foo bar?", nil)).to eq("foo bar ")
  end
+
+ it "substitutes empty parens '()' " do
+ expect(subject.substitute_special_chars("foo () bar", nil)).to eq("foo bar")
+ end
+
+ it "does not substitutes parens containing values " do
+ expect(subject.substitute_special_chars("foo (bar) baz", nil)).to eq("foo (bar) baz")
+ end
  end
 
  describe "#blacklight_params" do