Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isExternal to distinguish a source of the project #22

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

woin2ee
Copy link

@woin2ee woin2ee commented Jul 22, 2024

It's related to tuist/tuist#6436

So far, we've distinguished a project generated from Package.swift with isExternal, but in order to take one step further, we need to separate local from remote packages.

In current Tuist version, it already distinguishing them in several points. However we're aware of that assuming with the path is not ideal so, I propose this changes. Does it look fine?

Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for pushing these changes @woin2ee. I made some suggestions to enhance the API a bit and align us with future plans for the package.

Sources/XcodeGraph/Models/Project.swift Outdated Show resolved Hide resolved
@pepicrft
Copy link
Contributor

pepicrft commented Aug 8, 2024

@woin2ee I suggest that we merge this one once we have the changes working on the tuist side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants