-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert jupyter notebooks to python files #72
Convert jupyter notebooks to python files #72
Conversation
This all looks good to me. For the environment.yaml, is it important for all the package versions here: |
Great :) Most of the package versions do not need to be fixed, I added them such that the example outputs are reproducible. Of course, with a new tudatpy version these would then have to be updated. I agree that having one single environment would be nice. On the other hand you could argue that the tudatpy-examples toolchain has some dependencies that a regular user probably won't be using, like nbconvert and tqdm (although tqdm is more a nice-to-have than a must), so including them in the main tudat-space environment.yaml seems a bit out of place? |
Looks good, thanks. Doing the conversion between .ipynb and .py indeed shouldn't be that relevant for the average user. |
…ipts Convert jupyter notebooks to python files
This PR extends and updates the
create_scripts.py
utility to fix #22Major changes include:
create_scripts.py
a CLI app, without requests to the user in the command line during the conversionplt.show()
if it is not added in the notebook, fixes Show plots in auto-generated Python files #52The script was applied to all notebooks in the repository, no python file was modified afterwards. No more syntax errors are present.
Before merging
Please check if the generated python files are as desired :)
If you want to try the script yourself, make sure to use the
tudat-examples
conda environment from environment.yaml, specifically the nbconvert version specified there, as there were some changes that are not backwards compatible.