Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panelled arc wise scaling fator #269

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kimonito98
Copy link
Collaborator

Added arc-wise panelled scaling factor as estimatable parameters (parallel & perpendicular to source). Note: given that PaneledRadiationPressureTargetModel did NOT contain references to the scaling, I hat to adapt it, similar to the cannonball version.
Tested fixed relevant unitTestAccelerationPartials.cpp.

@DominicDirkx
Copy link
Member

Thanks for adding this PR! I'll do my best to have a look at it before the Christmas break :)

@DominicDirkx
Copy link
Member

I see the CI is failing with this error:

58/290 Test #46: test_electromagnetism_RadiationPressureAcceleration ..................***Failed 3.12 sec
Running 9 test cases...
unknown location(0): fatal error: in "test_radiation_pressure_acceleration/testRadiationPressureAcceleration_DynamicallyPanelunitestradedSource_CannonballTarget_LAGEOS": class std::runtime_error: Error: Target model is not a PaneledRadiationPressureTargetModel
D:\a\tudat\tudat\tests\src\astro\electromagnetism\unitTestRadiationPressureAcceleration.cpp(1283): last checkpoint

before diving into it, could you check whether this test works properly on your system?

Good news is all other tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants