Skip to content

Commit

Permalink
Ignoring failed test in MacOS was for debugging purposes only.
Browse files Browse the repository at this point in the history
Rename the ccache step to describe what it does.
Fix typo in referencing the matrix variable build type.
  • Loading branch information
niketagrawal committed Mar 19, 2024
1 parent 5c4df5d commit 4582bfe
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ jobs:
run: cmd /c "curl -fsSL https://raw.githubusercontent.com/tudat-team/tudat-resources-feedstock/master/recipe/post-link.bat | cmd"


- name: Setup ccache
- name: Cache previous compilation results using ccache
# This third party action will setup ccache on the runner and restore any previously saved cache. Caches are saved automatically by the action after a build.
uses: hendrikmuhs/[email protected]
with:
key: ${{ matrix.os }}-${{ matrix.type }}
key: ${{ matrix.os }}-${{ matrix.build_type }}


- name: Configure CMake
Expand Down Expand Up @@ -149,5 +149,4 @@ jobs:
working-directory: "${{ github.workspace }}/build"
# Execute tests defined by the CMake configuration. Note that --build-config is needed because the default Windows generator is a multi-config generator (Visual Studio generator).
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
# Prevent the action from failing if any of the tests fail by using `|| true`. This is placed temporarily because currently, some tests fail on MacOS, and if the action fails, the cache is not updated, which prevents testing of the cache feature on MacOS.
run: ctest --build-config ${{ matrix.build_type }} --output-on-failure -j4 || true
run: ctest --build-config ${{ matrix.build_type }} --output-on-failure -j4

0 comments on commit 4582bfe

Please sign in to comment.