Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixed_vector #34

Merged
merged 41 commits into from
Jun 1, 2021
Merged

Added fixed_vector #34

merged 41 commits into from
Jun 1, 2021

Conversation

Daddelhai
Copy link
Contributor

@Daddelhai Daddelhai commented Sep 10, 2020

Added a vector with fixed capacity.
Fixes Issue #31

Usage like a normal Vector.
✔ std::get<>() support
✔ forward iterator
✔ backward iterator
✔ insert, emplace, erase

@Daddelhai
Copy link
Contributor Author

Only a few Test available yet. More coming tomorrow.

@tilsche tilsche requested a review from bmario September 14, 2020 11:40
@tilsche
Copy link
Member

tilsche commented Sep 14, 2020

Open question: Howto / should we allow references as elements?

Copy link
Member

@bmario bmario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The methods which take depackage_func seems strange. Remove that.

include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Show resolved Hide resolved
@Daddelhai
Copy link
Contributor Author

Still no refs possible

@Daddelhai Daddelhai requested a review from bmario October 2, 2020 12:48
Copy link
Member

@bmario bmario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into noexcept and add it appropiately.

Regarding the tests, what is unique requirement of fixed vector compared to a standard vector? Add a test for that.

include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Show resolved Hide resolved
tests/fixed_vector_test.cpp Outdated Show resolved Hide resolved
tests/fixed_vector_test.cpp Show resolved Hide resolved
include/nitro/lang/fixed_vector.hpp Outdated Show resolved Hide resolved
@bmario bmario merged commit 2aabf21 into tud-zih-energy:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants