Skip to content

Commit

Permalink
fix(sample): Drop cpuid_metric event from sample writing.
Browse files Browse the repository at this point in the history
Since 8f3ac68, we do not support systems that do not have
perf_attr.context_switch anymore. This means that since then, samples
will always be enclosed in context switch events, removing the need for writing the
cpuid metric from samples.

Also remove src/perf/syscall/sample/writer.cpp. Apparently this is
completely dead code
  • Loading branch information
cvonelm committed Jun 21, 2024
1 parent 8e13667 commit ef12121
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 268 deletions.
4 changes: 0 additions & 4 deletions src/perf/sample/writer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,6 @@ bool Writer::handle(const Reader::RecordSampleType* sample)

update_current_thread(Process(sample->pid), Thread(sample->tid), tp);

cpuid_metric_event_.timestamp(tp);
cpuid_metric_event_.raw_values()[0] = sample->cpu;
otf2_writer_ << cpuid_metric_event_;

if (!has_cct_)
{
otf2_writer_.write_calling_context_sample(tp, cctx_manager_.sample_ref(sample->ip), 2,
Expand Down
264 changes: 0 additions & 264 deletions src/perf/syscall/sample/writer.cpp

This file was deleted.

0 comments on commit ef12121

Please sign in to comment.