AMX extension #68
Closed
AMX extension #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marenz2569
requested changes
Sep 24, 2024
include/firestarter/Environment/X86/Platform/SapphireRapidsConfig.hpp
Outdated
Show resolved
Hide resolved
CMakeLists.txt
Outdated
| @@ -39,7 +39,7 @@ git_submodule_update() | |||
|
|
|||
| if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") | |||
| else() | |||
| SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -O2 -fdata-sections -ffunction-sections") | |||
| SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mamx-int8 -mamx-tile -Wall -Wextra -O2 -fdata-sections -ffunction-sections") | |||
There was a problem hiding this comment.
-mamx-tile is necessary.
-mamx-int8 got removed.
| class AVX512_AMX_Payload final : public X86Payload { | ||
| public: | ||
| AVX512_AMX_Payload(asmjit::CpuFeatures const &supportedFeatures) | ||
| : X86Payload(supportedFeatures, {asmjit::CpuFeatures::X86::kAMX_BF16}, |
There was a problem hiding this comment.
Checking for the kAMX_BF16 feature may have prevented you from integrating the AMX code it into the AVX512 payload. Can we check this feature if the "AMX" meta-instruction is selection during the compilePayload step instead?
| SapphireRapidsConfig(asmjit::CpuFeatures const &supportedFeatures, | ||
| unsigned family, unsigned model, unsigned threads) | ||
| : X86PlatformConfig("SKL_XEONEP", 6, {85}, {1, 2}, 0, | ||
| {32768, 1048576, 1441792}, 1048576000, 1536, family, |
There was a problem hiding this comment.
I assume these values also have not been updated
Added requested changes in master. Update PR branch.
|
This PR has been closed in favour of #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.