Feature SAMO-IS - Improve the optimization #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems impressing, however, I have some additional TODOs:
|
rschoene
reviewed
Apr 4, 2022
|
|
||
| cmakeFlags = [ | ||
| "-DFIRESTARTER_BUILD_HWLOC=OFF" | ||
| "-DCMAKE_C_COMPILER_WORKS=1" | ||
| "-DCMAKE_CXX_COMPILER_WORKS=1" | ||
| "-DFIRESTARTER_LINK_STATIC=OFF" |
rschoene
reviewed
Apr 4, 2022
include/firestarter/Firestarter.hpp
Outdated
| @@ -116,6 +117,7 @@ class Firestarter { | |||
| const unsigned _individuals; | |||
| const std::string _optimizeOutfile; | |||
| const unsigned _generations; | |||
| const unsigned _maxEvaluations; | |||
There was a problem hiding this comment.
is it necessary here? can it be held in Optimizer/Algorithm/SAMO_IS.hpp only?
rschoene
reviewed
Apr 4, 2022
| @@ -85,7 +89,7 @@ void Population::append(Individual const &ind, std::vector<double> const &fit) { | |||
| for (auto const &v : fit) { | |||
| ss << v << " "; | |||
| } | |||
| firestarter::log::trace() << ss.str(); | |||
| // firestarter::log::trace() << ss.str(); | |||
There was a problem hiding this comment.
not relevant to this feature (as well as following changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the foundation for SAMO-IS support. A paper for the algorithm can be found here: Multiple surrogate assisted multiobjective optimization using improved pre-selection
Preliminary results:
--optimize=SAMO-IS -t 10 --preheat=240 --optimization-metric=metricq,perf-ipc --metric-path=libmetric-metricq.so --individuals=40 --generations=20 --nsga2-m=0.35 --max-evaluations=400Open TODOs: