Add comments feature

[tttzach]

I have coded a simple comments form into the website, the text typed into the box will be saved into a List structure and then contents in the List is returned right below the comment box.

[tttzach]

I have merged another walkthrough's PR with this one since this PR is somewhat small. I hope that's okay!

[tttzach]

Reminder to self: add final keyword to variables where possible

[tttzach]

I have implemented most of the suggestions and created a new tab specifically for the comments feature. That should be all the content for this walkthrough.

[gbuenoandrade]

Try adding this https://github.com/github/gitignore/blob/master/Java.gitignore to your .gitignore so you don't commit Java bytecode and other binaries you ended up adding to this PR.

[tttzach]

Try adding this https://github.com/github/gitignore/blob/master/Java.gitignore to your .gitignore so you don't commit Java bytecode and other binaries you ended up adding to this PR.

I see what you mean, sorry I should've caught that! That has been added to my .gitignore but I need to do a git remove cache to make git acknowledge the changes on my .gitignore and stop tracking the folders I've put in it. Thanks!

[tttzach]

I just did a lot of refactoring especially breaking up functions because it seemed like I didn't pay enough attention to the single responsibility principle last week. I've also implemented Gui's suggestions, thanks again!

[gbuenoandrade]

This looks great! Just added some "FYI" comments.

LGTM

[gbuenoandrade]

FYI: I mentioned to Austin that there's an overloading of this method that accepts java.lang.Iterable<Key> as parameter, so you could remove all those values with a single call, but that would involve casting results.asIterable() into java.lang.Iterable<Key> (stream().map() is a neat way of doing that), but that might be too much work here and end up being not worth it.

[tttzach]

I'll look into this towards the end of the week as I want to do some refactoring. I've created an issue so I won't forget about this #36 Thanks!

[tttzach]

@gbuenoandrade
Hi, this is what I have so far:

private void deleteAll(DatastoreService datastore, PreparedQuery results) {
    Iterable<Key> toDelete = (results.asIterable()).stream().map(entity -> {
      return entity.getKey();
    }).collect(Collectors.toList());
    datastore.delete(toDelete);
 }

but it seems that .stream() is undefined for the type Iterable<Entity> and I am not familiar with any other alternatives. Do you have anything in mind?

[antmar]

Code looks ok. Just some comments about PR scope, to follow up on discussion today.

• Changes to .gitignore should always go into a separate PR, because they never interact with any feature/code in your project
• The first commit should definitely have been a separate PR, because the functionality was subsequently removed. f49ecf0
• Each of these features could have been a separate PR:
  • Add and list comments
  • Limit # of comments displayed
  • Delete comments
  • Expanding grid / tabs

[tttzach]

Thanks for the comments @antmar, I'll definitely reduce my PR scope and follow the workflow that you have suggested on #34. The examples you gave are extremely helpful for me to visualize how my future PRs should look!

[tttzach]

Assigned @gbuenoandrade just for the follow up on #30 (comment)