Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.adoc #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PIesPnuema
Copy link

@PIesPnuema PIesPnuema commented Feb 26, 2023

Hi there! I edited few issues I ran into with some of the resource links. I removed the ones with 404 errors, added a direct link to the new CMake tutorial page (they moved there page). Lastly is one I am unsure about which is the "dockerfiles" link. The link went nowhere so I added the link to the official docker build site. I am not sure if that was the intended destination. Cheers.

Details:
Adjustments to DOCKER section

Adjustments to OTHER LINKS section.

Adjustments to DOCKER section
- Added link on line 89 to more docker details (Not sure if this was the intended resource)-> https://docs.docker.com/engine/reference/commandline/build/ 
Adjustments to OTHER LINKS section.
- Removed line 97 " * https://rix0r.nl/blog/2015/08/13/cmake-guide/[rix0r Modern CMake Blog]" https certifcate cannot be verified.
- Fixed link on line 98 -> Offiicial CMake Turtorial 
- Removed line 102 " * http://techminded.net/blog/modular-c-projects-with-cmake.html[Modular C++ Projects]" -> No longer exists responds with 404 Error
- Removed line 107 "  * https://www.johnlamp.net/cmake-tutorial.html[John Lamp - CMake Tutorial]" -> No longer exists responds with 404 Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant