Skip to content

Commit

Permalink
chore: remove last mentions of the old sandbox
Browse files Browse the repository at this point in the history
  • Loading branch information
tsyirvo committed Nov 26, 2024
1 parent c3f2346 commit 2fdc7fc
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 19 deletions.
14 changes: 9 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
- [Environments](#environments)
- [Internationalization](#internationalization)
- [Adding images](#adding-images)
- [Using the custom Sandbox](#using-the-custom-sandbox)
- [Using Storybook](#using-storybook)
- [Tests](#tests)
- [Formatting and type checking](#formatting-and-type-checking)
- [Github Actions](#github-actions)
Expand All @@ -24,7 +24,7 @@ It's a basic start, but with most of the common dependencies and tools I use so

Check the [React Native docs](https://reactnative.dev/docs/environment-setup) on how to properly setup your dev environment. It uses Expo with a custom Development Build, so you also need to setup [Expo tooling](https://docs.expo.dev/).

On the Developer Experience side, a test stack is setup (unit, functional and E2E), a CI on _Github Actions_, a custom _Storybook_, _TypeScript_ is also configured with _ESLint_ and _Prettier_. Commits are linted to automate the release workflows and the changelog generation.
On the Developer Experience side, a test stack is setup (unit, functional and E2E), a CI on _Github Actions_, _Storybook_, _TypeScript_ is also configured with _ESLint_ and _Prettier_. Commits are linted to automate the release workflows and the changelog generation.

There are also some utilities like:

Expand Down Expand Up @@ -140,11 +140,15 @@ To simplify adding new images to the project and optimizing them, you can run th
yarn image:add [path/to/the/image/to/add|path/to/the/folder]
```

## Using the custom Sandbox
## Using Storybook

A custom _Sandbox_ is configured with some basic examples and navigation. Once [StoryBook](https://storybook.js.org/) for React Native will support V8, I'll migrate to using that.
A _Storybook_ is configured with some basic stories.

To access it, you can access the dev menu on the device and select _Toggle Sandbox_ to have it shown in place of the app.
To access it, you simply have to run the app with the following command:

```
yarn start:storybook
```

## Tests

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@
"!**/app.config.ts",
"!**/**.e2e.ts",
"!src/components/icons/components/**",
"!src/sandbox/**",
"!**/stories/**",
"!**/**.types.ts"
]
},
Expand Down
7 changes: 4 additions & 3 deletions src/core/i18n/resources/en/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ export const messages = {
screenTitle: 'Home',
title: 'Navigate to another page',
},
sandbox: {
content: 'Access the Sandbox form the Dev Menu with {{command}}',
title: 'Sandbox',
storybook: {
content:
'Access Storybook by running the packager with "yarn start:storybook"',
title: 'Storybook',
},
tests: {
content: 'You can run tests with Jest or Maestro',
Expand Down
7 changes: 4 additions & 3 deletions src/core/i18n/resources/fr/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ export const messages: MessagesTypes = {
screenTitle: 'Accueil',
title: 'Naviguer vers une autre page',
},
sandbox: {
content: 'Accéder à la Sandbox depuis le menu de dev avec {{command}}',
title: 'Sandbox',
storybook: {
content:
'Accéder au Storybook en lançant le packager avec "yarn start:storybook"',
title: 'Storybook',
},
tests: {
content: 'Vous pouvez faire tourner les tests avec Jest ou Maestro',
Expand Down
9 changes: 2 additions & 7 deletions src/features/home/components/Informations.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useTranslation } from 'react-i18next';

import { IS_IOS } from '$core/constants';
import { Text } from '$shared/uiKit/primitives';

export const Informations = () => {
Expand All @@ -9,14 +8,10 @@ export const Informations = () => {
return (
<>
<Text mb="spacing_8" mt="spacing_24" variant="large">
{t('homeScreen.sandbox.title')}
{t('homeScreen.storybook.title')}
</Text>

<Text>
{t('homeScreen.sandbox.content', {
command: IS_IOS ? 'Cmd+R' : 'Cmd+M',
})}
</Text>
<Text>{t('homeScreen.storybook.content')}</Text>

<Text mb="spacing_8" mt="spacing_24" variant="large">
{t('homeScreen.tests.title')}
Expand Down

0 comments on commit 2fdc7fc

Please sign in to comment.