fix tests

tsullivan · Aug 20, 2024 · ec6b2f9 · ec6b2f9
1 parent 2cb78c7
commit ec6b2f9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 18 deletions.
diff --git a/x-pack/plugins/spaces/public/management/spaces_management_app.test.tsx b/x-pack/plugins/spaces/public/management/spaces_management_app.test.tsx
@@ -173,7 +173,7 @@ describe('spacesManagementApp', () => {
           css="You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop)."
           data-test-subj="kbnRedirectAppLink"
         >
-          Spaces View Page: {"capabilities":{"catalogue":{},"management":{},"navLinks":{}},"serverBasePath":"","http":{"basePath":{"basePath":"","serverBasePath":"","assetsHrefBase":""},"anonymousPaths":{},"externalUrl":{},"staticAssets":{}},"overlays":{"banners":{}},"notifications":{"toasts":{}},"spacesManager":{"onActiveSpaceChange$":{}},"spaceId":"some-space","history":{"action":"PUSH","length":1,"location":{"pathname":"/edit/some-space","search":"","hash":""}}}
+          Spaces View Page: {"capabilities":{"catalogue":{},"management":{},"navLinks":{}},"serverBasePath":"","http":{"basePath":{"basePath":"","serverBasePath":"","assetsHrefBase":""},"anonymousPaths":{},"externalUrl":{},"staticAssets":{}},"overlays":{"banners":{}},"notifications":{"toasts":{}},"spacesManager":{"onActiveSpaceChange$":{}},"spaceId":"some-space","history":{"action":"PUSH","length":1,"location":{"pathname":"/edit/some-space","search":"","hash":""}},"allowFeatureVisibility":true,"allowSolutionVisibility":true}
         </div>
       </div>
     `);

diff --git a/x-pack/plugins/spaces/public/management/view_space/footer.tsx b/x-pack/plugins/spaces/public/management/view_space/footer.tsx
@@ -47,24 +47,23 @@ export const ViewSpaceTabFooter: React.FC<Props> = ({
           </EuiFlexItem>
           <EuiFlexItem grow={true} />
 
+          <EuiFlexItem grow={false}>
+            <EuiButtonEmpty onClick={onClickCancel} data-test-subj="cancel-space-button">
+              Cancel
+            </EuiButtonEmpty>
+          </EuiFlexItem>
+
           {isDirty && (
-            <>
-              <EuiFlexItem grow={false}>
-                <EuiButtonEmpty onClick={onClickCancel} data-test-subj="cancel-space-button">
-                  Cancel
-                </EuiButtonEmpty>
-              </EuiFlexItem>
-              <EuiFlexItem grow={false}>
-                <EuiButton
-                  color="primary"
-                  fill
-                  onClick={onClickSubmit}
-                  data-test-subj="save-space-button"
-                >
-                  Update space
-                </EuiButton>
-              </EuiFlexItem>
-            </>
+            <EuiFlexItem grow={false}>
+              <EuiButton
+                color="primary"
+                fill
+                onClick={onClickSubmit}
+                data-test-subj="save-space-button"
+              >
+                Update space
+              </EuiButton>
+            </EuiFlexItem>
           )}
         </EuiFlexGroup>
       )}