Skip to content

Commit

Permalink
[Lens] Fix partition theme after ech upgrade (elastic#195269)
Browse files Browse the repository at this point in the history
## Summary

When I've updated elastic-charts with the last new version, the
`point.fill` parameter of lineSeriesStyle has changed in value. This
created an unwanted change also in the partition chart that was using
that style to color the partition sector borders.

I've removed the useless color override of `sectorLineStroke` in the
overwrite partition theme, leaving the control to use the chart theme.

I've also removed the possibility of unwanted changes for other
properties like `fontFamily` and in the `linkedText.textColor`.

In the same PR I've removed duplicated tests that where testing exactly
the same code/arguments/data, the only difference was the test name.

I've also refactored a bit the code, cleaning up the typings and
consolidating a bit the theme override logic
  • Loading branch information
markov00 authored Oct 8, 2024
1 parent 32a478c commit 653073f
Show file tree
Hide file tree
Showing 4 changed files with 153 additions and 337 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -378,19 +378,11 @@ const PartitionVisComponent = (props: PartitionVisComponentProps) => {
getPartitionTheme(
visType,
visParams,
chartBaseTheme,
containerDimensions,
rescaleFactor,
hasOpenedOnAggBasedEditor
),
[
visType,
visParams,
chartBaseTheme,
containerDimensions,
rescaleFactor,
hasOpenedOnAggBasedEditor,
]
[visType, visParams, containerDimensions, rescaleFactor, hasOpenedOnAggBasedEditor]
);

const fixedViewPort = document.getElementById('app-fixed-viewport');
Expand Down
Loading

0 comments on commit 653073f

Please sign in to comment.