Add enhacement for bootstrap kubelet ip #1
Conversation
tsorya
force-pushed
the
igal/bootstrap_node_ip
branch
from
24df27f to
045d89a
Compare
tsorya
changed the title
tsorya
force-pushed
the
igal/bootstrap_node_ip
branch
2 times, most recently
from
588bc96 to
3579541
Compare
| # Bootstrap External IP | ||
|
|
||
| ## Summary | ||
| When installing a new cluster with assisted-installer, you can set machine networks that will |
| The user can work around this by modifying the bootstrap ignition file; however, | ||
| this isn't a friendly experience. |
There was a problem hiding this comment.
| The user can work around this by modifying the bootstrap ignition file; however, | |
| this isn't a friendly experience. | |
| The user can work around this by modifying the bootstrap ignition file; however, | |
| this isn't a friendly experience. |
Don't mention it here, instead move it to alternatives
| interfaces for the cluster hosts. However, currently, you cannot configure | ||
| the bootstrap machine network using the same means. |
There was a problem hiding this comment.
| interfaces for the cluster hosts. However, currently, you cannot configure | |
| the bootstrap machine network using the same means. | |
| interfaces for the cluster hosts. However, users cannot configure | |
| the machine network for the bootstrap node. |
|
|
||
| ## Summary | ||
| When installing a new cluster with UPI, you can set machine networks that will | ||
| be set to `networkConfig` field in the `install-config.yaml` file to configure the control plane network |
There was a problem hiding this comment.
Consider adding what the machine network is used for..
on the nic connected to this network OCP will build the ovs bridge and all traffic between the nodes will be on this network.
| the bootstrap machine network using the same means. | ||
|
|
||
| ## Motivation | ||
|
|
There was a problem hiding this comment.
Here you should describe the problem they had in the BZ linked above
|
|
||
| ## Proposal | ||
|
|
||
| We will add a new fields, `bootstrapNodeIP` to allow for further customization of |
There was a problem hiding this comment.
I think this should be a subnet and not a specific IP.
There was a problem hiding this comment.
then it will require to run nodeip-configuration, kubelet doesn't know what is subnet, it requires ip. In case of setting subnet change will be much more complicated
There was a problem hiding this comment.
will add it as alternative
|
How is this related / different / affects openshift#1179 ? |
|
|
||
| ## Proposal | ||
|
|
||
| We will add a new fields, `bootstrapNodeIP` to allow for further customization of |
There was a problem hiding this comment.
How is this related / different / affects openshift#1179 ?
Bootstrap is different. Nodeip is script is not part of Bootstrap flow
There was a problem hiding this comment.
The enhancement that you pointed to is another part of making openshift network predictable. We will need both
There was a problem hiding this comment.
Bootstrap is different. Nodeip is script is not part of Bootstrap flow
But still, maybe the same configuration can be used to affect both ? (I may be way off, I don't completely understand the problem yet)
There was a problem hiding this comment.
We already added an option to os env for this but installer team asked for enhancement to set it in install config
| ## Proposal | ||
|
|
||
| We will add a new fields, `bootstrapNodeIP` to allow for further customization of | ||
| bootstrap host ip that should be used for kubelet configuration. We will use this field to set BootstrapNodeIP field in |
|
|
||
| ## Proposal | ||
|
|
||
| We will add a new fields, `bootstrapNodeIP` to allow for further customization of |
There was a problem hiding this comment.
Should bootstrapNodeIP perhaps be more generic (i.e. not just for bootstrap) and indirectly set the environment in openshift#1179 ?
There was a problem hiding this comment.
Don't think so. The only other alternative is to create some script that will read install config and set kubelet ip from machine cidr. It will require such script to be part of installer and somehow be brought with bootstrap ignition. I am not sure it is worth to complicate it but let's see it on broader discussion
|
|
||
| ## Proposal | ||
|
|
||
| We will add a new fields, `bootstrapNodeIP` to allow for further customization of |
There was a problem hiding this comment.
why plural "fields"? (I assume because you want to put it in both none and metal, but it's not currently clear from the text)
| ### API Extensions | ||
|
|
||
| We will add a new field to the baremetal and None platform sections of the | ||
| `install-config.yaml` file called `bootstrapNodeIP`. This is similar to the existing |
There was a problem hiding this comment.
Similar in what way? what's different about them?
|
|
||
| ## Alternatives | ||
|
|
||
| We can document the specific scenario, and offer the ignition-based workaround |
There was a problem hiding this comment.
What is the ignition based workaround?
There was a problem hiding this comment.
I'm asking because it's not clear from the text what are you referring to exactly (especially because you use the word "the", it sounds like you're referring to something particular the reader should know about, but I don't know what it is)
There was a problem hiding this comment.
Maybe instead of the you meant an, but regardless an example / some details would be nice
tsorya
force-pushed
the
igal/bootstrap_node_ip
branch
from
3579541 to
5ad2475
Compare
No description provided.