Skip to content

Commit

Permalink
Merge pull request openshift#1176 from wking/possessive-capability-typo
Browse files Browse the repository at this point in the history
enhancements/installer/component-selection: Fix "capabilities" -> "capability's" typo
  • Loading branch information
openshift-ci[bot] authored Jul 8, 2022
2 parents 77aa17d + 56b760b commit 7a1cdaa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion enhancements/installer/component-selection.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ Would expect this to go directly to GA once a design is agreed upon/approved.
Review presubmit results for your annotation pull request to ensure that:
1. The capability is being completely removed, without leaving dangling resources that you forgot to annotate.
2. CI suites which you expected to pass continue to pass.
You may find that some test-cases assume or require your capabilities presence, and they may need to grow logic to skip or alter the test conditions when your capability is not installed (like [this][bump-origin]).
You may find that some test-cases assume or require your capability's presence, and they may need to grow logic to skip or alter the test conditions when your capability is not installed (like [this][bump-origin]).
If your annotation addition spans multiple pull requests, either because the manifests being annotated span multiple repositories or because you also need to make test suite adjustments in other repositories), you may be able to [use cluster-bot][cluster-bot] to run tests on a release assembling multiple in-flight pull requests.
4. Introduce the new capablity name in the openshift/api repo, like [this][bump-api].
1. If no [versioned capability set](https://github.com/openshift/api/blob/8324d657dee1d594a8a7768e5569fea6a8f887a9/config/v1/types_cluster_version.go#L257-L291) exists for the current OCP version under development, introduce one as part of your pull request.
Expand Down

0 comments on commit 7a1cdaa

Please sign in to comment.