Sourcery Starbot ⭐ refactored tsoporan/fittrak #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Apr 15, 2023
| if not hasattr(obj, "exercise_type"): | ||
| return "N/A" | ||
|
|
||
| return obj.exercise_type.name | ||
| return obj.exercise_type.name if hasattr(obj, "exercise_type") else "N/A" |
There was a problem hiding this comment.
Function ExerciseAdmin.get_type refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
| if isinstance(v, list): | ||
| state[k] = clean_models(v) | ||
| else: | ||
| state[k] = clean_models([v]) | ||
|
|
||
| state[k] = clean_models(v) if isinstance(v, list) else clean_models([v]) |
There was a problem hiding this comment.
Function create_workout_event refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| return True if self.ended_at else False | ||
| return bool(self.ended_at) |
There was a problem hiding this comment.
Function Workout.is_finished refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity)
| # Must happen before as exercises require special handling | ||
| # TODO: Separate concerns? | ||
| exercise_types = workout_fields.pop("exercise_types", None) | ||
|
|
||
| if exercise_types: | ||
| if exercise_types := workout_fields.pop("exercise_types", None): |
There was a problem hiding this comment.
Function UpdateWorkout.mutate refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
This removes the following comments ( why? ):
# Must happen before as exercises require special handling
# TODO: Separate concerns?
Comment on lines
-66
to
+74
| sets = ( | ||
| if sets := ( | ||
| Set.objects.filter(exercise__in=exercises, is_active=True) | ||
| .values("repetitions", "weight", "unit") | ||
| .exclude(repetitions__isnull=True) | ||
| .exclude(weight__isnull=True) | ||
| ) | ||
|
|
||
| if sets: | ||
| ): | ||
| return sum( | ||
| [ | ||
| s["repetitions"] * convert_to_lbs(s["weight"], s["unit"]) | ||
|
|
||
| for s in sets | ||
| ] | ||
| s["repetitions"] * convert_to_lbs(s["weight"], s["unit"]) | ||
| for s in sets |
There was a problem hiding this comment.
Function WorkoutType.resolve_total_weight refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Replace unneeded comprehension with generator (
comprehension-to-generator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: