Added core_input_mouse.c example #41
Conversation
|
It doesn't seem like the |
| const raylibMOuseButtonMapping = { | ||
| 0: 0, | ||
| 1: 2, | ||
| 2: 1, | ||
| 3: 3, | ||
| 4: 4, | ||
| 5: 5, | ||
| 6: 6, | ||
| } |
There was a problem hiding this comment.
Such naive mapping is not needed imo, return this.currentMouseButton == button would suffice.
There was a problem hiding this comment.
It's needed because in later examples, it is important to have correct mapping for the right and middle click.
My previous commit just used return this.currentMouseButton == button but had to change it to accommodate mouse constant swap, there can also be swaps in 3,4,5,6 mouse buttons but I don't have a way to test them out
There was a problem hiding this comment.
@hiranyey is correct here. The mappings are not 1:1. See the differences below...
typedef enum {
MOUSE_BUTTON_LEFT = 0, // Mouse button left
MOUSE_BUTTON_RIGHT = 1, // Mouse button right
MOUSE_BUTTON_MIDDLE = 2, // Mouse button middle (pressed wheel)
MOUSE_BUTTON_SIDE = 3, // Mouse button side (advanced mouse device)
MOUSE_BUTTON_EXTRA = 4, // Mouse button extra (advanced mouse device)
MOUSE_BUTTON_FORWARD = 5, // Mouse button forward (advanced mouse device)
MOUSE_BUTTON_BACK = 6, // Mouse button back (advanced mouse device)
} MouseButton;Web API: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button#value
0: Main button pressed, usually the left button or the un-initialized state
1: Auxiliary button pressed, usually the wheel button or the middle button (if present)
2: Secondary button pressed, usually the right button
3: Fourth button, typically the Browser Back button
4: Fifth button, typically the Browser Forward button
| window.addEventListener("keydown", keyDown); | ||
| window.addEventListener("keyup", keyUp); | ||
| window.addEventListener("wheel", wheelMove); | ||
| window.addEventListener("mousemove", mouseMove); | ||
| window.addEventListener("mousedown", mouseClick); |
There was a problem hiding this comment.
I understand you're just adding IsMouseButtonPressed() right now, but could we also implement the other mouse functions here too?
IsMouseButtonPressed
IsMouseButtonDown
IsMouseButtonReleased
IsMouseButtonUp
The pattern is already implemented with keys, so could do the same here.
There was a problem hiding this comment.
Yeah, this is easy to do,
I will check if there are examples in Raylib using these new functions and include them in this PR
There was a problem hiding this comment.
In #52 , I wasn't able to find examples that used the related keyboard functions, so I wouldn't be surprised if examples don't exist.
Just a small change to make core_input_mouse.c working, but the mapping between raylib mouse constants and browser mouse constants are different.
For me, left button is showing correct color but right and middle button are swapped.
This patch implements
IsMouseButtonPressedand i cant test out
MOUSE_BUTTON_SIDE,MOUSE_BUTTON_EXTRA,MOUSE_BUTTON_FORWARD,MOUSE_BUTTON_BACKas i dont have those mouse buttons in any of my mousesTested other pages too and i can conclude that this patch wont create a regression in other pages.