Fix logging interference with worker and main thread #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexim
requested changes
Apr 4, 2020
There was a problem hiding this comment.
How does this fix the problem? The problem comes from the fact that the string Do you want to report this? [y/n] is printed without the newline to indicate that we are waiting a response from the user. The problem is still reproducible as it's described in the original issue.
Tbh, I have no what would be the best solution here...
|
This fixes the problem because the warnings are sent to the Before:
After:
As you can see it does not interfere with the output anymore like it does in the issue. Where is this problem still reproducible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #170