Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vod for your stream, you mentioned potentially checking with mypy.
This pull request does exactly that, adding complete type annotations to allow for type checking with mypy as well as the necessary configuration file for mypy.
I have made two minor functional changes that are noteworthy:
load_snapshots
instead so return type oflist[Snapshot]
is still usable and we don't need to make a separate copy of Snapshot typed dictionary.With mypy installed, program will be type checkable by running
in project root directory without any errors.