Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full type annotations for mypy #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CoolCat467
Copy link

@CoolCat467 CoolCat467 commented Jun 2, 2024

In the vod for your stream, you mentioned potentially checking with mypy.
This pull request does exactly that, adding complete type annotations to allow for type checking with mypy as well as the necessary configuration file for mypy.

I have made two minor functional changes that are noteworthy:

  1. Removing unused imports from typing module
  2. Decoding shell command bytes as utf-8 in load_snapshots instead so return type of list[Snapshot] is still usable and we don't need to make a separate copy of Snapshot typed dictionary.

With mypy installed, program will be type checkable by running

mypy rere.py

in project root directory without any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant