Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hotreload support for windows #90

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

Markos-Th09
Copy link
Contributor

Adds hotreload support for the niche video game operating system, for both msvc and mingw.

@rexim
Copy link
Member

rexim commented Mar 2, 2024

Is it suppose to work in wine as well? I haven't check the native Windows, but it crashes on wine with "Unhandled page fault on read access". It would be kinda cool if it worked in wine too. :(

@Markos-Th09 Markos-Th09 force-pushed the hotreload-windows branch 2 times, most recently from 156ee36 to 3b7aad2 Compare March 2, 2024 11:23
@Markos-Th09
Copy link
Contributor Author

Markos-Th09 commented Mar 2, 2024

Is it suppose to work in wine as well? I haven't check the native Windows, but it crashes on wine with "Unhandled page fault on read access". It would be kinda cool if it worked in wine too. :(

This is actually my fault, thank for pointing it out. I didn't realize the new resource loading added new plug functions after the bundling. For future reference after this is merged, make sure to add MUSIALIZER_PLUG before those to maintain windows compatibility.

@rexim
Copy link
Member

rexim commented Mar 2, 2024

@Markos-Th09 alright, looks good! Thank you!

@rexim rexim merged commit 5ba3e8d into tsoding:master Mar 2, 2024
4 checks passed
@Markos-Th09
Copy link
Contributor Author

@Markos-Th09 alright, looks good! Thank you!

On a completely unrelated note, why was #74 closed but this is accepted?

@Markos-Th09 Markos-Th09 deleted the hotreload-windows branch March 2, 2024 11:45
@Markos-Th09
Copy link
Contributor Author

also I did a bit of a messup check out #98

Jummit pushed a commit to Jummit/musializer that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants