Fix (most) typescript errors + use Vite #90
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakgoyal
commented
Aug 15, 2024
| "vite": "^5.4.0" | ||
| }, | ||
| "dependencies": { | ||
| "@dhdbstjr98/gif.js": "^1.0.2" |
There was a problem hiding this comment.
removes the need to manually download the gif.js files (gif.js, gif.map, gif.worker.js...)
sakgoyal
commented
Aug 15, 2024
serviceworker.ts
Outdated
There was a problem hiding this comment.
Vite has built in hot reloading
sakgoyal
commented
Aug 15, 2024
| */ | ||
| // interface HTMLElement { class : string } | ||
|
|
||
| export type Tag<T extends HTMLElement = HTMLElement> = T & { |
There was a problem hiding this comment.
use generic functions to fix the massive any problem. This solution is almost perfect but there are issues with some errors in some places
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do you want to use Vite or should I revert these changes and go back?
this has a major bug and does not work. I am unable to change any settings and they are not visible.