Add unary concurrency test #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only 1 out of 3 failed, multiple messages may need to be sent per process in order to catch this more reliably. |
|
Thanks! And maybe can just use common test's features to rerun tests until they pass to keep it running again and again. |
|
Ok, do you mean putting the concurrent test in its own group and using {repeat_until_any_fail, N} for it? |
|
@psalin yea |
psalin
force-pushed
the
add-unary-concurrency-test
branch
from
42dfdf8 to
0f06874
Compare
|
I updated the test and it revealed a server side concurrency issue and that the client will crash when that occurs, I created issues for those. |
|
Ok, cool, will get those fixed early this week most likely. |
|
Thanks, this was merged in with #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #39