Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The connection can break on concurrent unary requests #39

Closed
psalin opened this issue Jan 8, 2021 · 3 comments · Fixed by #42
Closed

The connection can break on concurrent unary requests #39

psalin opened this issue Jan 8, 2021 · 3 comments · Fixed by #42

Comments

@psalin
Copy link
Collaborator

psalin commented Jan 8, 2021

When running concurrent unary requests, HTTP/2 HEADERS frames are sometimes sent in an order where a lower stream identifier is sent after an already sent higher one. This causes a HTTP/2 connection error and breaks communication when it happens.

@psalin
Copy link
Collaborator Author

psalin commented Jan 8, 2021

It is actually this issue in chatterbox: joedevivo/chatterbox#136. An allocated stream identifier is not guaranteed to be sent out before the next one.

@tsloughter
Copy link
Owner

Do you have a test case for this? Should it "work" to test by just spawning a couple processes making unary requests on the same connection over and over until it blows up? Is it fairly consistent at blowing up or is it timing based?

@psalin
Copy link
Collaborator Author

psalin commented Jan 10, 2021

It is timing based and probably depends on where it is run but at least for me spawning 100 processes that send a unary request reproduces it consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants