Switch to only storing fixed node data in Prior #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 91.58% 91.94% +0.35%
==========================================
Files 5 5
Lines 1081 1067 -14
==========================================
- Hits 990 981 -9
+ Misses 91 86 -5
Continue to review full report at Codecov.
|
hyanwong
force-pushed
the
store-fixed-node-time-not-lik
branch
2 times, most recently
from
606d4ae
to
7187277
Compare
Prior is now a subclass of NodeGridValues, with the ability to store a time (*not* a likelihood) for fixed nodes.
hyanwong
force-pushed
the
store-fixed-node-time-not-lik
branch
from
7187277
to
de1ae7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised belatedly that fixed nodes do not need to store likelihood values for the prior, but times - i.e. all the likelihood is concentrated at a precise time (not just a time slice, but a floating point time value). Additionally, we don't want to change this during the inside or outside pass. So I've changed the NodeGridValues class to take out the fixed node stuff, and created a new
Priorsubclass that adds the ability to store a time (not a likelihood) for fixed nodes.This is not for merging yet - it is the first iteration of incorporating non-contemporaneous samples into tsdate.