Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malloc Q rather than from stack in multi-merger #2308

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jeromekelleher
Copy link
Member

Fixes segfault reported in #2307

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.99%. Comparing base (657fc8d) to head (6ac820a).

Files Patch % Lines
lib/msprime.c 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
- Coverage   91.03%   90.99%   -0.05%     
==========================================
  Files          20       20              
  Lines       12023    12035      +12     
  Branches     2439     2441       +2     
==========================================
+ Hits        10945    10951       +6     
- Misses        595      599       +4     
- Partials      483      485       +2     
Flag Coverage Δ
C 90.99% <50.00%> (-0.05%) ⬇️
python 98.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeromekelleher jeromekelleher merged commit 7492287 into tskit-dev:main Aug 5, 2024
13 of 14 checks passed
@jeromekelleher jeromekelleher deleted the beta-segfault branch August 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant