forked from sonic-net/sonic-utilities
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps #4
Open
tshalvi
wants to merge
5
commits into
master
Choose a base branch
from
master_adding_cmis_host_mgmt_files_to_show_techsupport
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps #4
tshalvi
wants to merge
5
commits into
master
from
master_adding_cmis_host_mgmt_files_to_show_techsupport
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshalvi
changed the title
Added CMIS host management-related files to the show techsupport dumps
Add CMIS Host Management Files to 'show techsupport' Dumps
Aug 22, 2024
tshalvi
changed the title
Add CMIS Host Management Files to 'show techsupport' Dumps
[Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps
Aug 22, 2024
DavidZagury
reviewed
Aug 25, 2024
DavidZagury
reviewed
Aug 25, 2024
DavidZagury
reviewed
Aug 25, 2024
…d to 'show interfaces autoneg status'
DavidZagury
reviewed
Aug 25, 2024
scripts/generate_dump
Outdated
local hwsku=$(python3 -c "from sonic_py_common import device_info; print(device_info.get_hwsku())") | ||
local sku_folder="/usr/share/sonic/device/${platform}/${hwsku}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
local sku_folder="/usr/share/sonic/device/${platform}/${hwsku}" | |
local sku_folder="${platform_folder}/${hwsku}" |
DavidZagury
approved these changes
Aug 25, 2024
DavidZagury
reviewed
Aug 25, 2024
DavidZagury
suggested changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the save_cmd functions to save the output of a commnad
…nd used save_cmd() instead of running the command directly and manually storing the output in a file
DavidZagury
reviewed
Aug 26, 2024
DavidZagury
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added the following CMIS host management-related files to the 'show techsupport' dumps (if they exist):
sai.profile, pmon_daemon_control.json, media_settings.json, optics_si_settings.json.
How I did it
How to verify it
Run 'show techsupport' and verify that the files are present in the following path within the generated dump: /etc/cmis-host-mgmt.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)