Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lab5] Adding CLI commands to show tx error status and configure relevant parameters #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Lab5] Adding CLI commands to show tx error status and configure relevant parameters #3

wants to merge 1 commit into from

Conversation

tshalvi
Copy link
Owner

@tshalvi tshalvi commented Dec 20, 2022 •
edited
Loading

What I did

I Added the following CLI commands:

  • config txargs_duration [x] - set the polling period of monitorTxOrch (doTask(timer)) to x
  • config txargs_threshold [x] - set the threshold of tx errors to x
  • show tx_monitor_interface data - show threshold and polling period configurations
  • show txstate summary - show the tx state (OK/NOT OK) for each of the switch's interfaces

How I did it

I added these new CLI commands to /config/main.py and /show/main.py

How to verify it

Run these commands to configure the params:

  1. "config txargs_duration 10"
  2. "config txargs_threshold 100"
  3. "show tx_monitor_interface data"
  4. verify the result is "{'duration': '10', 'threshold': '100}"

Run this command to show tx errors status for each port:

  1. "show txstate summary"

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@tshalvi tshalvi changed the title Added CLI commands to config tx error parameters and show tx state results [Lab5] Adding CLI commands to show tx error status and configure relevant parameters Dec 20, 2022
tshalvi pushed a commit that referenced this pull request Aug 22, 2024
@JunhongMao
[VOQ][saidump] Modify generate_dump: replace save_saidump with save_s…
cd85569 
…aidump_by_route_size (sonic-net#2972)

* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  #1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  #2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  #3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  #4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  #5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tshalvi