Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple EC_number tags for CDSs, lower case initials in /product descriptions for prokka-1.9.1-testing #18

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aleimba
Copy link

@aleimba aleimba commented May 30, 2014

New pull request to include multiple EC_number tags per CDS with version prokka-1.9.1-testing and some bug fixes

For this purpose the database format was adapted to include several EC_numbers separated by a semicolon, e.g.:

K9NBS6 3.5.1.13;3.5.1.14;3.5.1.4~~~aam~~~Acylamidase
MTEQNLHWLSATEMAASVASNNLSPNEIAEAMIQRVDAVNPS...

This is included in the necessary database preparations scripts:

  • prokka-biocyc_to_fasta_db
  • prokka-genbank_to_fasta_db
  • prokka-genpept_to_fasta_db
  • prokka-hamap_to_hmm
  • prokka-uniprot_to_fasta_db

prokka can handle this format now. As a result a new uniprot database in /db/kingdom/Bacteria/sprot is included.

Additionally, a couple of bug fixes:

This might warrant a new version, changed it to prokka-1.9.2.-testing. ChangeLog.txt is updated as well.

@aleimba
Copy link
Author

aleimba commented May 30, 2014

Forgot to mention, in prokka /gene and /EC_number feature tags are first removed (if it's a hypothetical protein) and subsequently added, see:
https://github.com/Victorian-Bioinformatics-Consortium/prokka/blob/master/bin/prokka#L915-931
Thus, I changed the order, to first add the tags and afterwards remove if hypothetical, see:
https://github.com/aleimba/prokka/blob/master/bin/prokka#L919-934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant