Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixed validation on props #293

Merged
merged 4 commits into from
Jun 19, 2024
Merged

bug fixed validation on props #293

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80bfebf
bug fixed validation on props
OwenMelbz May 24, 2024
93927cb
Merge branch 'master' into patch-1
tschoffelen May 30, 2024
526152b
Update src/utils.ts
tschoffelen Jun 18, 2024
3c2710e
Merge branch 'master' into patch-1
tschoffelen Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,19 +186,14 @@ export const checkOptions = ({
prefixes: Record<string, string>;
appsWhiteList: string[] | null | undefined;
}): void => {
if (!latitude || !longitude) {
if (!(latitude && longitude) && !address) {
throw new MapsException(
'`showLocation` should contain keys `latitude` and `longitude`.',
'`latitude` & `longitude` or `address` is required. Both cannot be undefined.',
);
}
if (address && typeof address !== 'string') {
throw new MapsException('Option `address` should be of type `string`.');
}
if (!latitude && !longitude && !address) {
throw new MapsException(
'`latitude` & `longitude` or `address` is required. Both cannot be undefined.',
);
}
if (title && typeof title !== 'string') {
throw new MapsException('`title` should be of type `string`.');
}
Expand Down