fix: fix PopupProps and improve types (close #282, #285) #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorlxy
changed the title
meteorlxy
force-pushed
the
meteorlxy/fix-types
branch
from
6a0c7d4 to
32bd01f
Compare
meteorlxy
commented
Apr 11, 2024
| }; | ||
| appsWhiteList?: string[]; | ||
| setIsVisible: (isVisible: boolean) => void; | ||
| options: ShowLocationProps; |
There was a problem hiding this comment.
That's the fix for #282. We should reuse ShowLocationProps type here.
meteorlxy
force-pushed
the
meteorlxy/fix-types
branch
from
bb6f30d to
fafb0b9
Compare
meteorlxy
commented
Apr 11, 2024
| @@ -17,9 +17,6 @@ import { Popup } from 'react-native-map-link'; | |||
| modalProps={{ // you can put all modal props inside. | |||
| animationIn: 'slideInUp' | |||
| }} | |||
| appsWhiteList={[ /* Array of apps (apple-maps, google-maps, etc...) that you want | |||
| to show in the popup, if is undefined or an empty array it will show all supported apps installed on device.*/ ]} | |||
| appTitles: {{ /* Optional: you can override app titles. */ }} | |||
There was a problem hiding this comment.
In fact appTitles won't take effect. It should be set in options.appTitles, and so does appsWhiteList. They are all available in options, so I removed them here.
tschoffelen
approved these changes
Apr 16, 2024
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #282, fixes #285:
PopupPropsdefinition