dbus server accepts parsing blur strength and added dbus example

[mvrozanti]

This one doesn't bloat stuff up and solves #14

I'm still wondering though, can we omit the parse_blur_strength call?

[tryone144]

Thanks for re-implementing in the dbus interface.

But I'm not quite shure how you want to change the parameters without a call to parse_blur_strength? Currently, the blur strength is tracked globally and directly set by said function.

[mvrozanti]

Yeah I don't know why I mentioned that actually

[tryone144]

As blur-strength is kept in the global state and applied to all windows, this would be a better fit in the opts_set category, don't you think? 😉

[mvrozanti]

Oops

I forgot to rename that. I was not sure if it had had conflicts with ps->o.blur_strength somehow

I'm also not sure how to add this to opts_set, I'm gonna try and find out

[tryone144]

I'm also not sure how to add this to opts_set, I'm gonna try and find out

There should be a generic handler:

compton/src/dbus.c

Line 1001 in 6dab09d

cdbus_process_opts_set(session_t *ps, DBusMessage *msg) {

[mvrozanti]

Is that last commit right..?

I also wanted to have the possibility to increment/decrement by a factor.

[tryone144]

Is that last commit right..?

Looks like you forgot to actually change the copied handler to update the blur-strength like the other one did...
The old win_set handler is misleading and should be removed, I think.

I also wanted to have the possibility to increment/decrement by a factor though.

This is a bit more difficult, as there is currently no way to read the numeric blur-strength value back. But this could be stored in the ps->o.blur_strength item as well. Just update the corresponding struct definition and the parse method to include the numeric value as well like here:

compton/src/common.h

Lines 554 to 559 in 0f86353

	typedef struct {
	int level;
	int iterations;
	float offset;
	int expand;
	} blur_strength_t;

compton/src/common.h

Lines 1709 to 1744 in 0f86353

	/**
	* Parse a blur_strength option argument.
	*/
	static inline bool
	parse_blur_strength(session_t *ps, const int level) {
	static const blur_strength_t values[20] = {
	{ .level = 1, .iterations = 1, .offset = 1.5 , .expand = 10 }, // 1
	{ .level = 2, .iterations = 1, .offset = 2.0 , .expand = 10 }, // 2
	{ .level = 3, .iterations = 2, .offset = 2.5 , .expand = 20 }, // 3
	{ .level = 4, .iterations = 2, .offset = 3.0 , .expand = 20 }, // 4
	{ .level = 5, .iterations = 3, .offset = 2.75 , .expand = 50 }, // 5
	{ .level = 6, .iterations = 3, .offset = 3.5 , .expand = 50 }, // 6
	{ .level = 7, .iterations = 3, .offset = 4.25 , .expand = 50 }, // 7
	{ .level = 8, .iterations = 3, .offset = 5.0 , .expand = 50 }, // 8
	{ .level = 9, .iterations = 4, .offset = 3.71429, .expand = 150 }, // 9
	{ .level = 10, .iterations = 4, .offset = 4.42857, .expand = 150 }, // 10
	{ .level = 11, .iterations = 4, .offset = 5.14286, .expand = 150 }, // 11
	{ .level = 12, .iterations = 4, .offset = 5.85714, .expand = 150 }, // 12
	{ .level = 13, .iterations = 4, .offset = 6.57143, .expand = 150 }, // 13
	{ .level = 14, .iterations = 4, .offset = 7.28571, .expand = 150 }, // 14
	{ .level = 15, .iterations = 4, .offset = 8.0 , .expand = 150 }, // 15
	{ .level = 16, .iterations = 5, .offset = 6.0 , .expand = 400 }, // 16
	{ .level = 17, .iterations = 5, .offset = 7.0 , .expand = 400 }, // 17
	{ .level = 18, .iterations = 5, .offset = 8.0 , .expand = 400 }, // 18
	{ .level = 19, .iterations = 5, .offset = 9.0 , .expand = 400 }, // 19
	{ .level = 20, .iterations = 5, .offset = 10.0 , .expand = 400 }, // 20
	};
	if (level < 1 || level > 20) {
	printf_errf("(\"%d\"): Invalid blur_strength argument. Needs to be a number between 1 and 20.", level);
	return false;
	}
	ps->o.blur_strength = values[level - 1];
	return true;
	}

This value should be accessible via a new dbus handler in opts_get. Increment and decrement should then be possible via the dbus interface.

[mvrozanti]

Does this look right? this dbus thing is kinda weird

[tryone144]

I guess it works... 😄
I'll take a look at it later.

[mvrozanti]

https://github.com/mvrozanti/compton/blob/05b5f30795fcb54a690b48e4ea112c82fdf58de5/src/dbus.c#L836

This looks pretty bad though x)