Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better Agent <=> Realm relationship #69

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Conversation

sno2
Copy link
Contributor

@sno2 sno2 commented Nov 5, 2023

We now pass around realms as identifier which allows us to avoid locking thanks to AapoAlas's idea.

We now pass around realms as identifier which allows us to avoid
locking thanks to AapoAlas's idea.
@sno2 sno2 mentioned this pull request Nov 6, 2023
aapoalas
aapoalas previously approved these changes Nov 7, 2023
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

nova_vm/src/ecmascript/execution/realm.rs Show resolved Hide resolved
@sno2 sno2 enabled auto-merge (squash) November 8, 2023 13:57
@aapoalas aapoalas enabled auto-merge (squash) November 24, 2023 18:29
@aapoalas aapoalas merged commit 2f0589e into main Nov 24, 2023
1 check passed
@aapoalas aapoalas deleted the feat/agent-realm-relation branch November 24, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants