fix(vm): Fix the ranges for SmallInteger
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `SmallInteger` represents numbers in two's complement, the
minimum value for that type is -2^55, rather than -2^55 + 1, even
though its maximum value is 2^55 - 1. This is because there are as
many negative numbers representable in the type as non-negative
numbers, but the non-negative numbers include zero. This patch updates
`SmallInteger::MIN_BIGINT` to reflect this.
This patch also updates `SmallInteger::{MIN,MAX}_NUMBER` to remove the
division by 2, to make them truly reflect Javascript's
`Number.{MIN,MAX}_SAFE_INTEGER`. It also changes the ranges in
`SmallInteger::from_i64_unchecked` and in the `TryFrom<i64>` impl to
use `{MIN,MAX}_BIGINT`, rather than `{MIN,MAX}_NUMBER`.
andreubotella
force-pushed
the
fix/small-integer-ranges
branch
from
6c55f51
to
eeb3aab
Compare
andreubotella
changed the title
SmallIntegerSmallInteger
aapoalas
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
SmallIntegerrepresents numbers in two's complement, the minimum value for that type is -2^55, rather than -2^55 + 1, even though its maximum value is 2^55 - 1. This is because there are as many negative numbers representable in the type as non-negative numbers, but the non-negative numbers include zero. This patch updatesSmallInteger::MIN_BIGINTto reflect this.This patch also updates
SmallInteger::{MIN,MAX}_NUMBERto remove the division by 2, to make them truly reflect Javascript'sNumber.{MIN,MAX}_SAFE_INTEGER. It also changes the ranges inSmallInteger::from_i64_uncheckedand in theTryFrom<i64>impl to use{MIN,MAX}_BIGINT, rather than{MIN,MAX}_NUMBER.