Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecmascript): Fix Value::is_* operations that didn't take all alternative variants into account #55

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix(ecmascript): Fix Value::is_* operations that didn't take all alternative variants into account #55

merged 1 commit into from
Oct 31, 2023

Conversation

andreubotella
Copy link
Collaborator

No description provided.

aapoalas
aapoalas approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The is_object is somewhat annoying to upkeep... Clippy doesn't like it but it might be worth it to turn it into an explicit check where all variants are mentioned.

@aapoalas aapoalas merged commit 00f5253 into main Oct 31, 2023
1 check passed
@aapoalas aapoalas deleted the fix/value-is-methods branch October 31, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreubotella @aapoalas