Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecmascript): Array.prototype.toSorted #467

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

CarrotzRule123
Copy link
Contributor

This PR implements Array.prototype.toSorted

@load1n9 load1n9 self-requested a review November 22, 2024 23:18
load1n9
load1n9 previously approved these changes Nov 22, 2024
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aapoalas
aapoalas previously approved these changes Nov 24, 2024
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One suggestion for a fast path.

@CarrotzRule123 CarrotzRule123 dismissed stale reviews from aapoalas and load1n9 via 89fa5ee November 25, 2024 15:50
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much. Great stuff <3

@aapoalas aapoalas merged commit 40857ee into trynova:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants