chore(ecmascript): Align PropertyKey discriminants with Value

trynova · Oct 31, 2023 · 4eeb0f1 · 4eeb0f1
1 parent c9ce9d4
commit 4eeb0f1
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/nova_vm/src/ecmascript/types/language/object/property_key.rs b/nova_vm/src/ecmascript/types/language/object/property_key.rs
@@ -1,7 +1,13 @@
 use crate::{
     ecmascript::{
         execution::Agent,
-        types::{String, Value},
+        types::{
+            language::value::{
+                INTEGER_DISCRIMINANT, SMALL_STRING_DISCRIMINANT, STRING_DISCRIMINANT,
+                SYMBOL_DISCRIMINANT,
+            },
+            String, Value,
+        },
     },
     heap::{
         indexes::{StringIndex, SymbolIndex},
@@ -11,11 +17,12 @@ use crate::{
 };
 
 #[derive(Debug, Clone, Copy, PartialEq)]
+#[repr(u8)]
 pub enum PropertyKey {
-    Integer(SmallInteger),
-    SmallString(SmallString),
-    String(StringIndex),
-    Symbol(SymbolIndex),
+    Integer(SmallInteger) = INTEGER_DISCRIMINANT,
+    SmallString(SmallString) = SMALL_STRING_DISCRIMINANT,
+    String(StringIndex) = STRING_DISCRIMINANT,
+    Symbol(SymbolIndex) = SYMBOL_DISCRIMINANT,
 }
 
 impl PropertyKey {