Fix graph hashmap key mangling on analysis service invoke #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimFuller-RedHat
force-pushed
the
minor-fix-analysis-service
branch
from
35c4592
to
8c73b8b
Compare
JimFuller-RedHat
force-pushed
the
minor-fix-analysis-service
branch
from
8c73b8b
to
7b70ed0
Compare
JimFuller-RedHat
force-pushed
the
minor-fix-analysis-service
branch
from
7b70ed0
to
63cc955
Compare
bobmcwhirter
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result.id strings out to a uuid prefixed with "urn:uuid" ... which when analysis service is invoked in ingestor results in 2 entries in graph hashmap of the same graph (e.g one with a key of normal hypenated uuid and the other with a urn:uuid prefix. That is because lazy loading uses just the unadorned uuid string ... so eventually between using REST API search (lazy loading) and ingestor we end up with two different entries in the hashmap of the same sbom - that was silly/wrong.
The fix chops off the urn:uuid bit from the string and its ugly - open to any better suggestions.