feat(sdk): Improved did:key create function #598
Conversation
DRK3
force-pushed
the
ImprovedDIDKeyCreateFunction
branch
from
b13c34d to
47f9383
Compare
| // Workaround: when the did:key VDR creates a DID for ed25519, Ed25519VerificationKey2018 is the expected | ||
| // verification method. | ||
| publicKeyBytes, err := jwk.JWK.PublicKeyBytes() | ||
| if err != nil { | ||
| return nil, wrapper.ToMobileError(err) |
There was a problem hiding this comment.
Should these be in go pkg rather than mobile binding pkg ?
There was a problem hiding this comment.
I was also wondering the same thing. I wasn't sure if we wanted this behaviour to be common to all bindings that use the Go SDK or if it should be specific to the binding implementation (gomobile, WASM). Since you were wondering the same thing, I think perhaps it makes more sense for it to be common, so I'll update the PR.
DRK3
force-pushed
the
ImprovedDIDKeyCreateFunction
branch
from
47f9383 to
3589737
Compare
Added a new function for creating did:key DIDs. This new standalone function directly takes in a key instead of a keyWriter or keyReader, giving the caller more flexibility in terms of key management. It also minimizes input parameters to only what's required, helping reduce confusion caused by unused parameters. Signed-off-by: Derek Trider <[email protected]>
DRK3
force-pushed
the
ImprovedDIDKeyCreateFunction
branch
from
3589737 to
c3e7434
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 89.83% 89.74% -0.10%
==========================================
Files 98 100 +2
Lines 3927 3960 +33
==========================================
+ Hits 3528 3554 +26
- Misses 265 271 +6
- Partials 134 135 +1
☔ View full report in Codecov by Sentry. |
Added a new function for creating did:key DIDs. This new standalone function directly takes in a key instead of a keyWriter or keyReader, giving the caller more flexibility in terms of key management. It also minimizes input parameters to only what's required, helping reduce confusion caused by unused parameters.