Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple multihash algorithms in protocol #526

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Dec 11, 2020

Add support for an array of multihash algorithms in protocol.

As per Sidetree working group the first version of the protocol should support one algorithm only and unique suffix should be calculated based on that version. Created follow-up issue for protocol version 2 (#528)

Closes #522

Signed-off-by: Sandra Vrtikapa [email protected]

@cla-bot cla-bot bot added the cla-signed label Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #526 (1c3e1f1) into master (188eb39) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          73       74    +1     
  Lines        3038     3087   +49     
=======================================
+ Hits         2788     2833   +45     
- Misses        141      143    +2     
- Partials      109      111    +2     
Impacted Files Coverage Δ
pkg/versions/0_1/operationparser/recover.go 93.87% <60.00%> (-1.92%) ⬇️
pkg/hashing/hash.go 92.85% <100.00%> (+0.26%) ⬆️
pkg/versions/0_1/client/create.go 94.44% <100.00%> (ø)
pkg/versions/0_1/model/util.go 95.34% <100.00%> (ø)
pkg/versions/0_1/operationparser/create.go 86.36% <100.00%> (ø)
pkg/versions/0_1/operationparser/update.go 91.83% <100.00%> (ø)
pkg/versions/0_1/txnprovider/provider.go 98.12% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188eb39...1c3e1f1. Read the comment docs.

@sandrask sandrask changed the title wip: support multiple multihash algorithms in protocol feat: support multiple multihash algorithms in protocol Dec 16, 2020
@sandrask sandrask merged commit 4a4bcf1 into trustbloc:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultihashAlgorithm (protocol parameter) should be an array of supported algorithms
3 participants