feat: Added multiselect story #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unrelated fix to the goal here
brandonlenz
reviewed
Oct 31, 2023
|
noticed the iOS safari image is different than the other happo images. This warrants pulling it up on an iPhone imo, but I do not have one myself. |
|
@shkeating same and same |
|
I have an iphone, but I'm not sure how I'd pull this up. Someone mind giving me a few instructions? |
|
You know i completely forgot we can use the Simulator app to run this stuff. With this branch running locally, all you have to do is launch a sim and use its built in safari to load it! For reference, here's how mdn's example multiselect looks: So I think the Happo diff is as expected and approvable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues or PRs
Addresses uswds/uswds#5268, in that this component was already working fine, but now you can see that it works fine.
How To Test
View "Multiselect" story for "Select" component, see ellipsis is added already via imported css, and set/unset the validation style in the storybook args
Screenshots (optional)