Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Delete deprecated Dropdown component #2644

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

brandonlenz
Copy link
Contributor

@brandonlenz brandonlenz commented Oct 25, 2023

Summary

BREAKING CHANGE: Use Select instead

Thanks to the way that Dropdown was previously deprecated, it was already rendering a Select behind the scenes, so for consumers its an easy 1:1 replace <Dropdown> with <Select>

Related Issues or PRs

closes #2416

How To Test

  • Dropdown no longer exists in the repo
  • Dropdown storybook examples no longer exist
  • Project builds because internal usage of Dropdown have been replaced

BREAKING CHANGE: Use Select instead
@brandonlenz brandonlenz self-assigned this Oct 25, 2023
@brandonlenz brandonlenz requested review from a team as code owners October 25, 2023 20:10
@brandonlenz
Copy link
Contributor Author

Silly me, missed some of our own usages of Dropdown. Well this PR is gonna also show consumers how to upgrade 😆

@github-actions
Copy link
Contributor

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 7622c67

@brandonlenz brandonlenz changed the title fix!: Delete deprecated Dropdown component feat!: Delete deprecated Dropdown component Oct 25, 2023
@brandonlenz brandonlenz merged commit 59dffd1 into main Oct 25, 2023
11 checks passed
@brandonlenz brandonlenz deleted the bl-delete-dropdown branch October 25, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Delete deprecated Dropdown component
2 participants