Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updates file input stories to set appropriate html for value of label #2628

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: Updates file input stories to set appropriate html for value of label #2628

merged 1 commit into from
Oct 13, 2023

Conversation

vinodkv2511
Copy link
Contributor

Summary

Associates label with the right input using htmlFor in withError story of file input.

Related Issues or PRs

closes #2609

How To Test

  1. Launch storybook and navigate to with error story of file input
    image
  2. Click open canvas in new tab button to open this story in a new tab
    image
  3. Run automated accessibility checker of choice on the page that opens to check for Form elements should have labels issue
  4. Should not see any Form elements should have labels

Screenshots (optional)

image

@vinodkv2511 vinodkv2511 requested a review from a team as a code owner October 11, 2023 16:38
@brandonlenz brandonlenz merged commit 7f51150 into trussworks:main Oct 13, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Merged
@vinodkv2511 vinodkv2511 deleted the vinodkv2511-fileInput-2609 branch October 16, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonlenz brandonlenz brandonlenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] labels must be correctly programmatically associated in file input examples
2 participants
@vinodkv2511 @brandonlenz