Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add design PR review documentation #2615

Merged
merged 3 commits into from
Oct 3, 2023
Merged

docs: add design PR review documentation #2615

merged 3 commits into from
Oct 3, 2023

Conversation

shkeating
Copy link
Contributor

@shkeating shkeating commented Oct 2, 2023 •
edited
Loading

Summary

Adds documentation about reviewing front end PRs for designers & non-engineers

Related Issues or PRs

#2614 [docs] add documentation for front end PR reviews

How to review

Go to the rich diffs view

@shkeating shkeating added type: documentation Improvements or additions to documentation Hacktoberfest labels Oct 2, 2023
@shkeating shkeating self-assigned this Oct 2, 2023
@shkeating shkeating requested a review from a team as a code owner October 2, 2023 20:14
brandonlenz
brandonlenz approved these changes Oct 3, 2023
View reviewed changes
docs/design-pr-reviews.md
Comment on lines +47 to +49
![meme of Pam Beesley shwoing Creed two identical photos on an episode of The Office (US) and asking him to spot the differences](https://lh3.googleusercontent.com/0CJGCVuHI2fqOhURfnV6xztELYpJUvb6iRgKYJ5uLd4HVDyWzNa9fClk74jegJ5PvTLZlrJ54OPu4OGFd7tm05OGp4DMnZdg2r-w8BWItCydmWdGZHPd8LpnzIAG0JUh9YQWCkygIIQk2ru69wLiN5pvUkXR2h-Oqr9NP5k1xiuj9ooBpaYjAmkDBA)

![Pam informing the viewer that the photos are the same picture, so there are no differences](https://lh3.googleusercontent.com/XAvh9ARUnK-WXittJtrgDkIqns_ykebb4woQgjUJgHNmqqPA1oOOG9FXosbLSyOR-2vuCTH4DyZ1gXG2Bt9_oCQ_h4MgGY0TIk8YtveG_qdUbnaxA-2mNUJoTDlQhpZxfXJGueKbayXHo9q4KsEsmX5Maq7nYZtYQKzDRZ4ryKMK898RZeg6xqfvNQ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

brandonlenz
brandonlenz approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thought is, should we link to this from somewhere else so that its easy to find/stumble on? Maybe a section in Contributing?

@shkeating shkeating merged commit 2892424 into main Oct 3, 2023
8 checks passed
@shkeating shkeating deleted the 2614-shk-design-pr-update-docs branch October 3, 2023 16:06
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
Merged
@shkeating shkeating mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonlenz brandonlenz brandonlenz approved these changes

Assignees

@shkeating shkeating

Labels
Hacktoberfest type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shkeating @brandonlenz